Skip to content

fail github actions when coverage threshold is not met#35

Merged
guoken1 merged 2 commits intomainfrom
ci_cov
Jul 31, 2025
Merged

fail github actions when coverage threshold is not met#35
guoken1 merged 2 commits intomainfrom
ci_cov

Conversation

@guoken1
Copy link
Contributor

@guoken1 guoken1 commented Jul 31, 2025

Issue
The unit test github action is passing when the coverage threshold has not been met, due to rounding of the actual coverage percentage:
image

Description of changes:

  • fail github actions and pre-commit hooks if the coverage threshold is not reached (by adding a precision parameter)
  • get coverage threshold from pyproject.toml instead of overriding with command arg

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@guoken1 guoken1 requested review from siwachabhi and sundargthb July 31, 2025 20:49
@guoken1 guoken1 self-assigned this Jul 31, 2025
@guoken1 guoken1 requested review from siwachabhi and sundargthb July 31, 2025 22:39
@guoken1 guoken1 changed the title update cov-fail-under fail github actions when coverage threshold is not met Jul 31, 2025
@guoken1 guoken1 merged commit a15ecb8 into main Jul 31, 2025
16 checks passed
@guoken1 guoken1 deleted the ci_cov branch July 31, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants